/[smecontribs]/rpms/mailman/contribs7/mailman-python-compile.patch
ViewVC logotype

Annotation of /rpms/mailman/contribs7/mailman-python-compile.patch

Parent Directory Parent Directory | Revision Log Revision Log | View Revision Graph Revision Graph


Revision 1.1 - (hide annotations) (download)
Mon Apr 21 00:12:42 2008 UTC (16 years, 6 months ago) by slords
Branch: MAIN
CVS Tags: mailman-2_1_5_1-34_rhel4_6_el4_sme
Initial import of mailman-2.1.5.1-34.rhel4.6.el4.sme.src.rpm

1 slords 1.1 This patch is to fix bug #137863
2    
3     https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=137863
4    
5     The problem arose when the SELinux security policy detected mailman
6     attempting to open files under /usr/src/build (i.e. the buildroot
7     where the RPM is created). It was a bit of a mystery what in mailmain
8     was causing access to a hardcoded absolute path that only exists on
9     the machine mailman was built on and doesn't exist on the machine it
10     was installed on. It was finally determined the path had been embedded
11     in the .pyc files when they were compiled during the build
12     process. These path names are used as debug output when exceptions
13     occur in the .pyc file (e.g. file, line number in stack traces). The
14     SELinux security violations occurred only after a python exception
15     occurred in mailman. The solution to supply the "ddir" parameter
16     (debug directory) in the compile_dir function call. Given that mailman
17     expects to build on the machine and in its install directory it was
18     never necessary to suppy a "ddir" parameter in addition to "dir"
19     because they were the same. But when building for an alternate
20     installation it is necessary to supply both parameters because they
21     are different. Note in the default case of building on the target both
22     $(DESTDIR)$(prefix)" and "$(prefix)" will evaluate to the same value
23     and the original behavior will be retained.
24    
25     The compile_dir command used to recurse from the $(prefix)/Mailman
26     root to find .py files, but this missed .py files also located here:
27    
28     $(prefix)/bin
29     $(prefix)/cron
30     $(prefix)/pythonlib
31     $(prefix)/scripts
32     $(prefix)/tests
33    
34     In particular it missed $(prefix)/pythonlib. When $(prefix)/pythonlib
35     was added a new problem was observed, that path contained pre-compiled
36     .pyc files that are unpacked from a codecs tar file and since the .pyc
37     files already existed in the tar file the compile_dir command skipped
38     compiling them. This resulting in leaving the wrong debug path in the
39     .pyc file (the ddir arg to compile_dir). Therefore we added "force" to
40     the compile_dir command and started the directory recursion one level
41     higher.
42    
43     diff -u -r mailman-2.1.5.orig/Makefile.in mailman-2.1.5.pyc/Makefile.in
44     --- mailman-2.1.5.orig/Makefile.in 2003-03-31 14:26:57.000000000 -0500
45     +++ mailman-2.1.5.pyc/Makefile.in 2004-11-09 12:49:42.000000000 -0500
46     @@ -124,7 +124,7 @@
47     do \
48     (cd $$d; $(MAKE) DESTDIR=$(DESTDIR) install); \
49     done
50     - $(PYTHON) -c 'from compileall import *; compile_dir("$(DESTDIR)$(prefix)/Mailman")'
51     + $(PYTHON) -c 'from compileall import *; compile_dir("$(DESTDIR)$(prefix)", 20, "$(prefix)", 1)'
52    
53     # Only run bin/update if we aren't installing in DESTDIR, as this
54     # means there are probably no lists to deal with, and it wouldn't

admin@koozali.org
ViewVC Help
Powered by ViewVC 1.2.1 RSS 2.0 feed