smeserver-crontab_manager/contribs10/smeserver-crontab_manager-2.4-unitialised_values.patch

diff -Nur smeserver-crontab_manager-2.4.old/root/usr/share/perl5/vendor_perl/esmith/FormMagick/Panel/cronmanager.pm smeserver-crontab_manager-2.4/root/usr/share/perl5/vendor_perl/esmith/FormMagick/Panel/cronmanager.pm
--- smeserver-crontab_manager-2.4.old/root/usr/share/perl5/vendor_perl/esmith/FormMagick/Panel/cronmanager.pm   2013-03-05 19:11:08.000000000 +0100
+++ smeserver-crontab_manager-2.4/root/usr/share/perl5/vendor_perl/esmith/FormMagick/Panel/cronmanager.pm       2014-06-08 05:03:20.159117931 +0200
@@ -222,7 +222,7 @@
 sub change_cron_entry {
     my ($self) = @_;
     my $name = $self->cgi->param('name');
-    my $id = $self->cgi->param('id');
+    my $id = $self->cgi->param('id') || "";
     my $action = $self->cgi->param('action2');
     
     $self->wherenext('First');
@@ -448,7 +448,7 @@
 
 sub give_numeric {
     my ($self, $fld) = @_;
-    my $id = $self->cgi->param('id');
+    my $id = $self->cgi->param('id') || "";
 
     my %conf;
     tie %conf, 'esmith::config';
@@ -625,7 +625,7 @@
 
 sub give_bool {
     my ($self, $fld) = @_;
-    my $id = $self->cgi->param('id');
+    my $id = $self->cgi->param('id') || "";
 
     my %conf;
     tie %conf, 'esmith::config';
@@ -636,11 +636,14 @@
     my @cron_entry;
     my $cron_entry;
     my $ret;
-    
+    my $fld_value;
+
     $value=db_get_prop(\%conf, "cronmanager","task$id") || "";
     @cron_entry=split(/,/, $value);
+    
+    $fld_value=$cron_entry[$fld] || "";
 
-    if ($cron_entry[$fld] eq 'YES') {
+    if ($fld_value eq 'YES') {
         $ret="YES";
     } else {
         $ret="NO";
1	brianr	1.1	diff -Nur smeserver-crontab_manager-2.4.old/root/usr/share/perl5/vendor_perl/esmith/FormMagick/Panel/cronmanager.pm smeserver-crontab_manager-2.4/root/usr/share/perl5/vendor_perl/esmith/FormMagick/Panel/cronmanager.pm
2			--- smeserver-crontab_manager-2.4.old/root/usr/share/perl5/vendor_perl/esmith/FormMagick/Panel/cronmanager.pm 2013-03-05 19:11:08.000000000 +0100
3			+++ smeserver-crontab_manager-2.4/root/usr/share/perl5/vendor_perl/esmith/FormMagick/Panel/cronmanager.pm 2014-06-08 05:03:20.159117931 +0200
4			@@ -222,7 +222,7 @@
5			sub change_cron_entry {
6			my ($self) = @_;
7			my $name = $self->cgi->param('name');
8			- my $id = $self->cgi->param('id');
9			+ my $id = $self->cgi->param('id') \|\| "";
10			my $action = $self->cgi->param('action2');
11
12			$self->wherenext('First');
13			@@ -448,7 +448,7 @@
14
15			sub give_numeric {
16			my ($self, $fld) = @_;
17			- my $id = $self->cgi->param('id');
18			+ my $id = $self->cgi->param('id') \|\| "";
19
20			my %conf;
21			tie %conf, 'esmith::config';
22			@@ -625,7 +625,7 @@
23
24			sub give_bool {
25			my ($self, $fld) = @_;
26			- my $id = $self->cgi->param('id');
27			+ my $id = $self->cgi->param('id') \|\| "";
28
29			my %conf;
30			tie %conf, 'esmith::config';
31			@@ -636,11 +636,14 @@
32			my @cron_entry;
33			my $cron_entry;
34			my $ret;
35			-
36			+ my $fld_value;
37			+
38			$value=db_get_prop(\%conf, "cronmanager","task$id") \|\| "";
39			@cron_entry=split(/,/, $value);
40			+
41			+ $fld_value=$cron_entry[$fld] \|\| "";
42
43			- if ($cron_entry[$fld] eq 'YES') {
44			+ if ($fld_value eq 'YES') {
45			$ret="YES";
46			} else {
47			$ret="NO";