smeserver-crontab_manager/contribs8/smeserver-crontab_manager-2.2_unitialised_values.patch

diff -Nur smeserver-crontab_manager-2.2.old/root/usr/lib/perl5/site_perl/esmith/FormMagick/Panel/cronmanager.pm smeserver-crontab_manager-2.2/root/usr/lib/perl5/site_perl/esmith/FormMagick/Panel/cronmanager.pm
--- smeserver-crontab_manager-2.2.old/root/usr/lib/perl5/site_perl/esmith/FormMagick/Panel/cronmanager.pm       2014-06-08 05:15:41.386343652 +0200
+++ smeserver-crontab_manager-2.2/root/usr/lib/perl5/site_perl/esmith/FormMagick/Panel/cronmanager.pm   2014-06-08 05:23:59.405626600 +0200
@@ -222,7 +222,7 @@
 sub change_cron_entry {
     my ($self) = @_;
     my $name = $self->cgi->param('name');
-    my $id = $self->cgi->param('id');
+    my $id = $self->cgi->param('id') || '';
     my $action = $self->cgi->param('action2');
     
     $self->wherenext('First');
@@ -448,7 +448,7 @@
 
 sub give_numeric {
     my ($self, $fld) = @_;
-    my $id = $self->cgi->param('id');
+    my $id = $self->cgi->param('id') || '';
 
     my %conf;
     tie %conf, 'esmith::config';
@@ -625,7 +625,7 @@
 
 sub give_bool {
     my ($self, $fld) = @_;
-    my $id = $self->cgi->param('id');
+    my $id = $self->cgi->param('id') || "";
 
     my %conf;
     tie %conf, 'esmith::config';
@@ -636,11 +636,14 @@
     my @cron_entry;
     my $cron_entry;
     my $ret;
-    
+    my $fld_value;
+        
     $value=db_get_prop(\%conf, "cronmanager","task$id") || "";
     @cron_entry=split(/,/, $value);
-
-    if ($cron_entry[$fld] eq 'YES') {
+    
+    $fld_value=$cron_entry[$fld] || "";
+     
+    if ($fld_value eq 'YES') {
         $ret="YES";
     } else {
         $ret="NO";
1	stephdl	1.1	diff -Nur smeserver-crontab_manager-2.2.old/root/usr/lib/perl5/site_perl/esmith/FormMagick/Panel/cronmanager.pm smeserver-crontab_manager-2.2/root/usr/lib/perl5/site_perl/esmith/FormMagick/Panel/cronmanager.pm
2			--- smeserver-crontab_manager-2.2.old/root/usr/lib/perl5/site_perl/esmith/FormMagick/Panel/cronmanager.pm 2014-06-08 05:15:41.386343652 +0200
3			+++ smeserver-crontab_manager-2.2/root/usr/lib/perl5/site_perl/esmith/FormMagick/Panel/cronmanager.pm 2014-06-08 05:23:59.405626600 +0200
4			@@ -222,7 +222,7 @@
5			sub change_cron_entry {
6			my ($self) = @_;
7			my $name = $self->cgi->param('name');
8			- my $id = $self->cgi->param('id');
9			+ my $id = $self->cgi->param('id') \|\| '';
10			my $action = $self->cgi->param('action2');
11
12			$self->wherenext('First');
13			@@ -448,7 +448,7 @@
14
15			sub give_numeric {
16			my ($self, $fld) = @_;
17			- my $id = $self->cgi->param('id');
18			+ my $id = $self->cgi->param('id') \|\| '';
19
20			my %conf;
21			tie %conf, 'esmith::config';
22			@@ -625,7 +625,7 @@
23
24			sub give_bool {
25			my ($self, $fld) = @_;
26			- my $id = $self->cgi->param('id');
27			+ my $id = $self->cgi->param('id') \|\| "";
28
29			my %conf;
30			tie %conf, 'esmith::config';
31			@@ -636,11 +636,14 @@
32			my @cron_entry;
33			my $cron_entry;
34			my $ret;
35			-
36			+ my $fld_value;
37			+
38			$value=db_get_prop(\%conf, "cronmanager","task$id") \|\| "";
39			@cron_entry=split(/,/, $value);
40			-
41			- if ($cron_entry[$fld] eq 'YES') {
42			+
43			+ $fld_value=$cron_entry[$fld] \|\| "";
44			+
45			+ if ($fld_value eq 'YES') {
46			$ret="YES";
47			} else {
48			$ret="NO";