General cleanups, sent upstream on 2009-03-26. diff -ur watchdog-5.6/include/extern.h watchdog-5.6-cleanup/include/extern.h --- watchdog-5.6/include/extern.h 2009-03-13 12:46:57.000000000 +0000 +++ watchdog-5.6-cleanup/include/extern.h 2009-03-26 10:15:51.000000000 +0000 @@ -71,4 +71,11 @@ void do_shutdown(int errorcode); void sigterm_handler(int arg); -void terminate(void); + +#ifdef __GNUC__ +#define GCC_NORETURN __attribute__((noreturn)) +#else +#define GCC_NORETURN +#endif + +void terminate(void) GCC_NORETURN; diff -ur watchdog-5.6/src/watchdog.c watchdog-5.6-cleanup/src/watchdog.c --- watchdog-5.6/src/watchdog.c 2009-03-22 12:52:24.000000000 +0000 +++ watchdog-5.6-cleanup/src/watchdog.c 2009-03-26 10:12:43.000000000 +0000 @@ -25,6 +25,7 @@ #include #include #include +#include #include #define __USE_GNU #include @@ -690,7 +691,7 @@ driver default) */ if (ioctl(watchdog, WDIOC_SETTIMEOUT, &devtimeout) < 0) { #if USE_SYSLOG - syslog(LOG_ERR, "cannot set timeout %s (errno = %d = '%m')", strerror(errno), devtimeout, errno); + syslog(LOG_ERR, "cannot set timeout %d (errno = %d = '%m')", devtimeout, errno); #else perror(progname); #endif diff -ur watchdog-5.6/src/wd_keepalive.c watchdog-5.6-cleanup/src/wd_keepalive.c --- watchdog-5.6/src/wd_keepalive.c 2009-03-12 14:30:07.000000000 +0000 +++ watchdog-5.6-cleanup/src/wd_keepalive.c 2009-03-26 10:19:05.000000000 +0000 @@ -34,6 +34,8 @@ #include #endif +#include "extern.h" + #define TRUE 1 #define FALSE 0