/[smeserver]/rpms/e-smith-manager/sme9/e-smith-manager-2.6.0-bz9920.badredirection.patch
ViewVC logotype

Contents of /rpms/e-smith-manager/sme9/e-smith-manager-2.6.0-bz9920.badredirection.patch

Parent Directory Parent Directory | Revision Log Revision Log | View Revision Graph Revision Graph


Revision 1.1 - (show annotations) (download)
Tue Jan 17 00:01:32 2017 UTC (7 years, 4 months ago) by unnilennium
Branch: MAIN
CVS Tags: e-smith-manager-2_6_0-13_el6_sme
* Mon Jan 16 2017 Jean-Philipe Pialasse <tests@pialasse.com> 2.6.0-13.sme
- fix bad redirection parameter that might reveal session information to remote site [SME: 9920]

1 diff -Nur e-smith-manager-2.6.0.old/root/etc/e-smith/web/common/cgi-bin/login e-smith-manager-2.6.0/root/etc/e-smith/web/common/cgi-bin/login
2 --- e-smith-manager-2.6.0.old/root/etc/e-smith/web/common/cgi-bin/login 2017-01-16 18:17:33.780000000 -0500
3 +++ e-smith-manager-2.6.0/root/etc/e-smith/web/common/cgi-bin/login 2017-01-16 18:59:16.748000000 -0500
4 @@ -160,8 +160,7 @@
5 # If $back domain doesn't match $AUTH_DOMAIN, pass ticket via back GET param
6 my $domain = $AUTH_DOMAIN || $server_name;
7 if ($b->host !~ m/\b$domain$/i) {
8 - $back .= $b->query ? '&' : '?';
9 - $back .= $at->cookie_name . '=' . $tkt;
10 + $fatal="Bad redirection parameter: \"$back\" is not an authorized redirection.<br />\nYou may be experiencing an attack.<br />\nLogin is not possible on the above URL for your own security.<br />\nPlease manually enter the address you were trying to reach if you followed a link.";
11 }
12
13 # For some reason, using a Location: header doesn't seem to then see the

admin@koozali.org
ViewVC Help
Powered by ViewVC 1.2.1 RSS 2.0 feed